fix: Restore label check for all actions using pull_request_target by jeremyary · Pull Request #3978 · feast-dev/feast
Conversation
What this PR does / why we need it:
Restore or add conditional label check to any action jobs utilizing pull_request_target to ensure manual screening of included changes occurs prior to PR hook checkout/execution of fork branch payloads.
Which issue(s) this PR fixes:
Fixes #3684
Signed-off-by: Jeremy Ary <jary@redhat.com>
Comment on lines 15 to +17
| ((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || | ||
| (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) || | ||
| github.repository != 'feast-dev/feast' | ||
| (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && | ||
| github.repository == 'feast-dev/feast' |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if anyone can speak as to why we'd want the original inverse truthy check, PLMK - afaict, it doesn't make sense to me that we'd want to execute when non-feast repo and ignore any label checks, so I've matched the check to all the others.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Labels
2 participants
