chore: Increase snowflake-connector-python dependency to 3.7 by bushwhackr · Pull Request #4008 · feast-dev/feast
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
What this PR does / why we need it: change in snowflake signature fetch_arrow_all in snowflake-connector-python 3.7.
This fixes linting issues and forces users to use the updated method.
Refer to #3952 and upstream fix: snowflakedb/snowflake-connector-python#1800
Which issue(s) this PR fixes:
Fixes #
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
chore: increase snowflake-connector-python to 3.7
chore: Increase snowflake-connector-python dependency to 3.7
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
| pa_table = execute_snowflake_statement( | ||
| return execute_snowflake_statement( | ||
| self.snowflake_conn, self.to_sql() | ||
| ).fetch_arrow_all(force_return_table=False) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bug, right? Wouldn't this already raise an exception for <3.7 versions?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@sudohainguyen Could you add the okay-to-test label, just to make sure that all the integration tests works.