feat: Make RegistryServer writable by tokoko · Pull Request #4231 · feast-dev/feast
What this PR does / why we need it:
- This PR adds apply/delete endpoints to the grpc registry server, also makes necessary changes in
remoteregistry that call those endpoints.
Which issue(s) this PR fixes:
Fixes #4216
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| import os |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot being deleted here. Can you update the PR notes to explain why? I'm not fully familiar with the usage of all of these tests so I'd like to make sure I understand the implications of removing all of these tests (along with the other files).
|
|
||
|
|
||
| @pytest.mark.integration | ||
| @pytest.mark.parametrize( |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
| @@ -1,69 +0,0 @@ | |||
| import assertpy | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
| @@ -1,60 +0,0 @@ | |||
| import assertpy | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add more details to the PR notes for this? Looks like we're removing a lot of tests and I'd like to make sure I understand the consequences of doing so as I'm not familiar with the usage of those tests.
Updated the PR description, let me know if it needs more clarity.
Thanks for updating the PR description.
Can you separate the removal of the tests into another PR? It'd be much cleaner in case we need to revert it.
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!