◐ Shell
clean mode source ↗

fix: Remove self assignment code line. by shuchu · Pull Request #4238 · feast-dev/feast

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@shuchu

@shuchu shuchu commented

May 30, 2024

Copy link Copy Markdown

Collaborator

Fixes

#4234

Signed-off-by: Shuchu Han <shuchu.han@gmail.com>

@shuchu shuchu enabled auto-merge (squash)

May 30, 2024 02:28

@sudohainguyen sudohainguyen left a comment

Copy link Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shuchu shuchu merged commit e514f66 into feast-dev:master

May 31, 2024

franciscojavierarceo pushed a commit that referenced this pull request

Jun 18, 2024
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18)

### Bug Fixes

* Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8))
* Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce))
* Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76))
* Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57))
* Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1))
* Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66))
* Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438))

### Features

* Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384))
* Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da))
* Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9))
* Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831))
* Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662))
* Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c))
* List all feature views ([#4256](#4256)) ([36a574d](36a574d))
* Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143))
* Remote offline Store  ([#4262](#4262)) ([28a3d24](28a3d24))
* Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudohainguyen sudohainguyen sudohainguyen approved these changes

@tokoko tokoko Awaiting requested review from tokoko

@HaoXuAI HaoXuAI Awaiting requested review from HaoXuAI

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove the self assignment in "sdk/python/tests/utils/e2e_test_validation.py" at line 179

2 participants

@shuchu @sudohainguyen