fix: CGO Memory leak issue in GO Feature server by EXPEbdodla · Pull Request #4291 · feast-dev/feast
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
What this PR does / why we need it:
Releases the memory used by CGOArrowAllocator. Not releasing the memory causing the memory leaks. Pods restart after all the memory allocated by container is filled up.
Which issue(s) this PR fixes:
NA
Fixes
- Memory leak in GO feature server which is causing the pod restarts after allocated memory filled up
- Sets the response content type to application/json (Before its application/text type)
- Added health check endpoint for GO HTTP feature server
pr-integration-tests failure is not related to this code change.
@EXPEbdodla All commits need a sign-off. Follow instructions here, git rebase HEAD~3 --signoff and then git push --force-with-lease origin fix_memory_leak.
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
redhatHameed pushed a commit to RHEcosystemAppEng/feast that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters