build: Explicit protobuf build version; consistent build/setup deps by cburroughs · Pull Request #4472 · feast-dev/feast
Right now if one downloads feast-0.40.1-py2.py3-none-any.whl from PyPi it contains:
$ grep 'Protobuf Python Version' feast/protos/feast/registry/RegistryServer_pb2.py
Which is outside
$ grep 'protobuf<' feast-0.40.1.dist-info/METADATA
Requires-Dist: protobuf<5.0.0,>=4.24.0
Leading to runtime errors (#4437). This was mitigated by #4438. This change tightens this up further by:
- Deleting the Makefile command that was trying to do this unsuccessfully.
- Aligns the setup/build requirements
- Sets the version of protobuf to match the minimum of the range. There is no guarantee that protos generated by
4.Xwill work with4.(X-1).