chore: Updated snowflake test to be more explicit about post apply entity_columns return value by franciscojavierarceo · Pull Request #4603 · feast-dev/feast
…tity_column return value Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo added a commit that referenced this pull request
…tity_columns return value (#4603) chore: updated snowflake test to be more explicit about post apply entity_column return value Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo added a commit that referenced this pull request
…ews (#4585) * merged changes Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * saving progress Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merged changes to odfv Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * linted Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * adding the test needed to show the expected behavior Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated test case Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * saving progress Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merging Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merged Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merged Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merging Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * adding the entity keys for now to do retrieval Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * adding entity to odfv Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * checking in progress...getting closer Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * may have to revert some of this...looks like the challenge is getting the entities correct when storing writes. just checking in progress Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * moving things around to make it easier to debug Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * debugging Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merged Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merging Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * Rebasing and merging changes from other PR Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * Merging changes continued Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * update the _make_inference to include odfvs with writes in the update map Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * have the table being written now...the create table happens in the SqliteOnlineStore.update() method Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * checking in progress Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * adding logs Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updating permissions Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * going to error out on purpose Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * adding unit test and merging changes Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * almost got everything working and type validation behaving Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * cleaned up and have tests behaving Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * adding print Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * removing print Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * checking in progress Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updating test Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * adding test Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * linted and updated Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * removed print Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated tests to test actual behavior Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * checking in progress Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * changing typo Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updating test Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * testing changes Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * checking to see if thing still working Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * removed print Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * undo change for odfv file Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated tests Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * okay well have the unit test working Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * type changes, hope i dont regret them Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated stream feature view piece Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated sfv ifelse Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * removing print Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * formatted and updated test Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * resolving some linter errors Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * fixed linter and formatting Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * okay think it is working Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * linter Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated type map for integration tests Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updated local feature store test Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * fixed local fs test Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * chore: Updated snowflake test to be more explicit about post apply entity_columns return value (#4603) chore: updated snowflake test to be more explicit about post apply entity_column return value Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * merging Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * fixed test to entity_rows_to_read Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * resolved inf conflicts Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * lint Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * Updated tests and lint, think I have everything working Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> --------- Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request
lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters