◐ Shell
clean mode source ↗

fix: Bigquery dataset create table disposition by danbaron63 · Pull Request #4649 · feast-dev/feast

added 6 commits

October 18, 2024 15:37
…gration tests, added self param to a method that was failing linting and ignoring other issues

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
…n get_historical_features is called

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
…o kwargs in the repo_configuration integration tests

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
…o fix due to length of type required and imports

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

@danbaron63 danbaron63 changed the title Bigquery dataset create table disposition fix: bigquery dataset create table disposition

Oct 18, 2024

@danbaron63 danbaron63 changed the title fix: bigquery dataset create table disposition fix: Bigquery dataset create table disposition

Oct 18, 2024

emgeee pushed a commit to emgeee/feast that referenced this pull request

Oct 23, 2024
* fix: adding self to a method which is failing linting in file.py integration tests, added self param to a method that was failing linting and ignoring other issues

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* fix: added create_table_disposition check when creating a dataset when get_historical_features is called

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* fix: ignoring some mypy linting errors caused by expanding a dict into kwargs in the repo_configuration integration tests

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* ignoring typing in auth_permissions_util that would be unreasonable to fix due to length of type required and imports

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* fixing method declaration that has no self parameter

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* made xdist_group methods static

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

---------

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

emgeee pushed a commit to emgeee/feast that referenced this pull request

Oct 23, 2024
* fix: adding self to a method which is failing linting in file.py integration tests, added self param to a method that was failing linting and ignoring other issues

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* fix: added create_table_disposition check when creating a dataset when get_historical_features is called

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* fix: ignoring some mypy linting errors caused by expanding a dict into kwargs in the repo_configuration integration tests

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* ignoring typing in auth_permissions_util that would be unreasonable to fix due to length of type required and imports

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* fixing method declaration that has no self parameter

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

* made xdist_group methods static

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

---------

Signed-off-by: Dan Baron <dan.baron@starlingbank.com>

lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request

Oct 29, 2024

lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request

Oct 29, 2024