fix: Feast create empty online table when FeatureView attribute online=False by tmihalac · Pull Request #4666 · feast-dev/feast
Conversation
What this PR does / why we need it:
Currently Feast create an empty online table even if FeatureView attribute online=False, this PR aims to fix that.
Which issue(s) this PR fixes:
Fixes #4616
| tables_to_keep_online = [ | ||
| fv | ||
| for fv in tables_to_keep | ||
| if not isinstance(fv, FeatureView) or fv.online |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if everying feature view will have a "online" parameter?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaoXuAI I saw that only feature view and the subclasses(batch feature view, stream feature view) that inherit from it have the online flag
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the API might change in the future, so to avoid breaking, maybe add a check if it has this attribute.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…e=False Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request
…e=False (feast-dev#4666) Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
