feat: Support for nested timestamp fields in Spark Offline store by EXPEbdodla · Pull Request #4740 · feast-dev/feast
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
| return table | ||
|
|
||
|
|
||
| def _get_fields_with_aliases( |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably would be good to add a test for this but i won't block on it.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have a direct test but pull_latest_query tests will use it. I'll add explicit tests in next PRs.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you for this!
Resolved merge conflicts with another commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters