feat: Adding vector_search parameter to fields by franciscojavierarceo · Pull Request #4855 · feast-dev/feast
Conversation
What this PR does / why we need it:
This PR adds vector_index and vector_search_metric to the Feature protobuf object (which maps to the Field class) that will be used to declare field-level index behavior for online retrieval. I.e., during ingestion we can declare which fields are indexed as vectors for approximate nearest neighbor search.
- Update protobuf objects (and impacted protobuf objects)
- Update class
- Update Sphinx documentation
Which issue(s) this PR fixes:
N/A
Misc
N/A
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…oing to ignore them so it is backwards compatible Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all changes in the sdk/python/feast/protos/feast/core/ folder seem due to some missed compilation of protos in a previous commit, and not related to your actual change, right?
apart of that, lgtm
Yeah it looks like it. I'll make an action to run some checks to verify it from now on.
Labels
2 participants
