chore: Add Milvus to pr_integration_tests.yml by franciscojavierarceo · Pull Request #4891 · feast-dev/feast
Add Milvus to pr_integration_tests.yml
chore: Add Milvus to pr_integration_tests.yml
| - name: Setup Milvus Cluster | ||
| run: | | ||
| wget https://github.com/milvus-io/milvus/releases/download/v2.4.20/milvus-standalone-docker-compose.yml -O docker-compose.yml | ||
| docker compose up -d |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to tear down the cluster before ending the job?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why do we need both one in action and services? do we need at both places? Looks like we are following the same pattern for redis as well.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some benefits for services but for Milvus, the service isn't necessary. I just followed what I thought was the convention but it's not necessary. I'll update the PR. 👍
dharmisha pushed a commit to nishantgaurav-dev/feast that referenced this pull request
* Add Milvus to pr_integration_tests.yml * upgrading to v2.5.1 and removing milvus service key
