feat: Operator improvements by tchughesiv · Pull Request #4928 · feast-dev/feast
What this PR does / why we need it:
Several small operator fixes & enhancements, including -
- Makes DeploymentStrategy configurable via CR
- Adds support for setting product container images via operator deployment "RELATED_IMAGE_" env vars (through kustomize). This lays the groundwork for ODH/RHOAI integration, custom product images, & disconnected k8s/openshift cluster deployments.
- OLM bundle generation to demonstrate
relatedImagesfunctionality - Adds ability to disable the `feast repo initialization' and the 'grpc healthcheck' initContainers
- Adds a reconcile check for local feast service config in CR
- Improves ephemeral storage setup and use among the feast services
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
| return DefaultImage | ||
| } | ||
|
|
||
| func getGrpcCurlImage() string { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why is this image needed? I see it being used to get the k8 service account. Why is this step needed?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think understood. waiting for the registry server to be up before spinning up the online and offline containers. not sure about the field disableInitContainers
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disableInitContainers adds ability to disable the `feast repo initialization' and the 'grpc healthcheck' initContainers if the user chooses to do so.
| - name: RELATED_IMAGE_FEATURE_SERVER | ||
| value: feast:latest | ||
| - name: RELATED_IMAGE_GRPC_CURL | ||
| value: grpc:latest |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, but i was also wanting to make this configurable via Makefile var for things like our e2e CI, etc
tmihalac pushed a commit to opendatahub-io/feast that referenced this pull request
operator improvements Signed-off-by: Tommy Hughes <tohughes@redhat.com>
