feat: ignore ipynb files during apply by gabrielaugz · Pull Request #5177 · feast-dev/feast
What this PR does / why we need it:
Ignore Jupyter Notebook Files extensions when using feast apply
Which issue(s) this PR fixes:
Fixes #5145
| p.resolve() | ||
| for p in repo_root.glob("**/*.py") | ||
| if p.is_file() and "__init__.py" != p.name | ||
| and not p.name.endswith(".ipynb") # Ignore Jupyter Notebook files during feast apply |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also if you can add .ipynb_checkpoints to ignore
| p.resolve() | ||
| for p in repo_root.glob("**/*.py") | ||
| if p.is_file() and "__init__.py" != p.name | ||
| and not p.name.endswith(".ipynb") # Ignore Jupyter Notebook files during feast apply |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this a list of files we ignore and add .ipynb to it?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, I see .ipynb_checkpoints in the ignore_paths but I have experienced this issue locally very frequently.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me too, I just used to do find . -name ".ipynb_checkpoints" -type d -exec rm -rf {} +
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i do something similar
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
closing in favor of #6151