◐ Shell
clean mode source ↗

fix: Fixed integration tests for qdrant and milvus by ntkathole · Pull Request #5224 · feast-dev/feast

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ntkathole

What this PR does / why we need it:

Fixed integration tests for milvus and qdrant.

make test-python-universal-milvus-online

make test-python-universal-qdrant-online
  • sdk/python/feast/feature_store.py
    - Removed override of distance_metric in _retrieve_from_online_store. This was always overriding distance_metric with default value of vector_search_metric even wrong value is passed. It's required only in v2 method. It was added in feat: Adding support to return additional features from vector retrieval for Milvus db #4971 .

  • sdk/python/feast/infra/online_stores/qdrant_online_store/qdrant.py

    • Fixed json.loads() when get_list_val_str returns None. In online_write_batch(), we are assuming that every value will be a a vector/embedding. But some of the features (like string_feature: "a") are not embeddings.
  • sdk/python/tests/integration/feature_repos/repo_configuration.py

    • Fixed entity_key_serialization_version set logic.
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

franciscojavierarceo

@YassinNouh21

jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request

Jun 7, 2025
Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>

jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request

Jun 7, 2025

Labels