fix: Fixed integration tests for qdrant and milvus by ntkathole · Pull Request #5224 · feast-dev/feast
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
What this PR does / why we need it:
Fixed integration tests for milvus and qdrant.
make test-python-universal-milvus-online
make test-python-universal-qdrant-online
-
sdk/python/feast/feature_store.py
- Removed override of distance_metric in _retrieve_from_online_store. This was always overriding distance_metric with default value of vector_search_metric even wrong value is passed. It's required only in v2 method. It was added in feat: Adding support to return additional features from vector retrieval for Milvus db #4971 . -
sdk/python/feast/infra/online_stores/qdrant_online_store/qdrant.py
- Fixed
json.loads()whenget_list_val_strreturnsNone. Inonline_write_batch(), we are assuming that every value will be a a vector/embedding. But some of the features (likestring_feature: "a") are not embeddings.
- Fixed
-
sdk/python/tests/integration/feature_repos/repo_configuration.py
- Fixed entity_key_serialization_version set logic.
jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters