chore: Refactor transform on write by franciscojavierarceo · Pull Request #5300 · feast-dev/feast
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
What this PR does / why we need it:
Refactored code to make it easier toread.
Which issue(s) this PR fixes:
Misc
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me.
But long term I think it's better to refactor with a factory pattern or an abstraction to avoid so many conditions check.
jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request
Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels
2 participants
