fix: Consistency in allow_cache and savedDatasets api by ntkathole · Pull Request #5572 · feast-dev/feast
What this PR does / why we need it:
This PR adds :
- allow_cache param in GetFeatureRequest API to be consistent with all other apis.
- Rename saved_datasets to savedDatasets in response to be consistent with other apis.
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
| assert "saved_datasets" in response_data | ||
| assert isinstance(response_data["saved_datasets"], list) | ||
| assert len(response_data["saved_datasets"]) == 1 | ||
| assert "savedDatasets" in response_data |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so was this always wrong?
| saved_datasets = response.get("savedDatasets", []) | ||
|
|
||
| result = { | ||
| "saved_datasets": saved_datasets, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i see. why this changed?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters