◐ Shell
clean mode source ↗

feat: Feast dataframe phase1 by HaoXuAI · Pull Request #5611 · feast-dev/feast

HaoXuAI

Conversation

@HaoXuAI

A simple interface for FeastDataFrame. This will be used as an abstraction for different kinds of dataframes in the life cycle of feast operations.
Check more design in issue #5581

What this PR does / why we need it:

Which issue(s) this PR fixes:

#5581

Misc

 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>

HaoXuAI

# limitations under the License.

from typing import TYPE_CHECKING, Any, Dict, List, Union
from typing import TYPE_CHECKING, Any, Dict, List, TypeAlias, Union

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow mypy linkting failed. this fixed it.

 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>

ntkathole

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Labels

2 participants

@HaoXuAI @ntkathole