feat: Add aggregation in OnDemandFeatureView by HaoXuAI · Pull Request #5629 · feast-dev/feast
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc
Signed-off-by: hao-xu5 <hxu44@apple.com>
Add aggregation in OnDemandFeatureView
feat: Add aggregation in OnDemandFeatureView
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only including it, is the execution already supported?
this is only including it, is the execution already supported?
Yeah It's only adding the API but the behind compute engine should be able to use it for batch compute
cool, i'd recommend adding a test for it just to show.
cool, i'd recommend adding a test for it just to show.
yep, not completed yet. need to update the proto as well
Signed-off-by: hao-xu5 <hxu44@apple.com>
Signed-off-by: hao-xu5 <hxu44@apple.com>
Signed-off-by: hao-xu5 <hxu44@apple.com>
Yeah just did, I didn't see a test showing the usage fwiw
Yeah just did, I didn't see a test showing the usage fwiw
Oh god forgot it. Will add in next pr