feat: Added codeflare-sdk to requirements by ntkathole · Pull Request #5640 · feast-dev/feast
Hey is this necessary dependency?
Codeflare-sdk is required for handling authentication, certs and making connection to Kuberay. I am going to add support for this in upcoming PRs by adding codeflare wrapper above current implementation. This will be completely optional as a end user, User can use simply use ray address to connect to remote cluster as well, if ray cluster do not need authentication or tls certs.
can we outline the benefits of having the codeflare SDK here?
Codeflare-sdk allows us:
- To find existing KubeRay cluster and connect without need to perform manual steps such as setting up tls certs configuration.
from codeflare_sdk import TokenAuthentication
from codeflare_sdk import generate_cert, get_cluster
- User don't need to know cluster details, just name and namespace of Ray cluster.
- Eliminates need to manually deploy and configure Ray clusters in Kubernetes.
I will add this in our documentation once implementation is done.
Or maybe create another dep like "Ray-clodeflakre"
We can do this, but it could be redundant. I am thinking anyhow codeflare-sdk will pull ray as it's dependency and usually ray needs same version for both server and client. If we did it like this, we don't need to maintain the ray version and let codeflare-sdk handle the compatibility.