feat: Add Set as feature type by Copilot · Pull Request #5888 · feast-dev/feast
Copilot
AI
changed the title
[WIP] Add support for set as feature type in feast
feat: Add Set as feature type
- Add 8 Set value types (BYTES_SET, STRING_SET, INT32_SET, INT64_SET, DOUBLE_SET, FLOAT_SET, BOOL_SET, UNIX_TIMESTAMP_SET) - Implement Set class with base type validation (no nested Sets/Maps) - Add type conversion logic with duplicate removal - Generate protobuf bindings and update type stubs - Add comprehensive tests and documentation for Set types Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
- Fix IndexParams len() check by tracking indices_added flag - Fix Unicode decode error for Set types by including them in numeric_vector_list_types - Fix Unicode decode error for complex types by using base64 encoding instead of decode() - Fix duplicate timestamp fields in Milvus insertion by filtering them from values_dict - Add missing timestamp field names to exclusion list in schema creation Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
The test was providing string values for item_id field which is defined as Int64 in the schema, causing protobuf serialization issues that could manifest as Unicode decode errors. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Extract the long set type handling code from _python_value_to_proto_value into a dedicated _python_set_to_proto_values function for better readability and maintainability. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
YassinNouh21 pushed a commit to YassinNouh21/feast that referenced this pull request
YassinNouh21 pushed a commit to YassinNouh21/feast that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters