◐ Shell
clean mode source ↗

test: Expand MilvusOnlineStore integration test coverage by korbonits · Pull Request #6299 · feast-dev/feast

devin-ai-integration[bot]

@korbonits korbonits changed the title test: expand MilvusOnlineStore integration test coverage test: Expand MilvusOnlineStore integration test coverage

Apr 20, 2026

ntkathole

Adds three cases to test_retrieve_online_milvus_documents that exercise
code paths adjacent to recent MilvusOnlineStore bug fixes (feast-dev#6275):

1. Empty-store query before any writes — verifies the v2 retrieval path
   returns 0 rows instead of raising when the collection exists but is
   empty.

2. Oversized top_k (top_k=5 on a 3-row dataset) — verifies the hit-parsing
   loop handles a result set smaller than the requested top_k and returns
   all available rows.

3. Cosine-metric variant via a second FeatureView with
   vector_search_metric="COSINE" — verifies the cosine index path end
   to end (write, index creation, retrieval).

No new imports; all types were already imported in the module.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Alex Korbonits <alex@korbonits.com>