More exhaustive athena types by Marcus-Rosti · Pull Request #6544 · feast-dev/feast
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
What this PR does / why we need it:
There's a lot of uncovered athena types -- so I tried to include them all
Which issue(s) this PR fixes:
Checks
- I've made sure the tests are passing.
- My commits are signed off (
git commit -s) - My PR title follows conventional commits format
Testing Strategy
- Unit tests
- Integration tests
- Manual tests
- Testing is not required for this change
Misc
Signed-off-by: Marcus Rosti <marcus.rosti@baton.io>
|
|
||
| type_map = { | ||
| "null": ValueType.UNKNOWN, | ||
| "null": ValueType.NULL, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder though if we should keep this for backwards compat?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 participant
