Reorder package.svg to fix the icon when filled by remi-marchand-zip · Pull Request #1275 · feathericons/feather

remi-marchand-zip

I noticed that when the package icon is 'filled', the top bit of the box is covered up, making it look like the box icon. Example:

By re-ordering the svg elements, the icon remains the same but fill works. Example:

Change:

diff --git a/icons/package.svg b/icons/package.svg
index 1349a8d..ae4c094 100644
--- a/icons/package.svg
+++ b/icons/package.svg
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
- <line x1="16.5" y1="9.4" x2="7.5" y2="4.21"/>
  <path d="M21 16V8a2 2 0 0 0-1-1.73l-7-4a2 2 0 0 0-2 0l-7 4A2 2 0 0 0 3 8v8a2 2 0 0 0 1 1.73l7 4a2 2 0 0 0 2 0l7-4A2 2 0 0 0 21 16z"/>
  <polyline points="3.27 6.96 12 12.01 20.73 6.96"/>
  <line x1="12" y1="22.08" x2="12" y2="12"/>
+ <line x1="16.5" y1="9.4" x2="7.5" y2="4.21"/>
</svg>

Test plan

I tested the icon by checking how it looked in its default state (fill="none") before and after. I then tested again with a fill that I added (fill="yellow") to confirm that I fixed it.