◐ Shell
clean mode source ↗

test(pydantic-ai): Consolidate binary blob redaction tests to stop relying on SDK internals by alexander-alderman-webb · Pull Request #5946 · getsentry/sentry-python

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Lost test coverage for URL without media_type kwarg
    • I restored the missing no-media_type URL test case and clarified IDs by separating no-media_type and with-media_type variants in the parametrized test.

Create PR

Or push these changes by commenting:

Preview (f942f46d76)
diff --git a/tests/integrations/pydantic_ai/test_pydantic_ai.py b/tests/integrations/pydantic_ai/test_pydantic_ai.py
--- a/tests/integrations/pydantic_ai/test_pydantic_ai.py
+++ b/tests/integrations/pydantic_ai/test_pydantic_ai.py
@@ -2812,9 +2812,15 @@
         ),
         pytest.param(
             "https://example.com/api?data=iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs",
+            {},
+            "https://example.com/api?data=iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs",
+            id="http_url_with_base64_query_param_no_media_type",
+        ),
+        pytest.param(
+            "https://example.com/api?data=iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs",
             {"media_type": "image/png"},
             "https://example.com/api?data=iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs",
-            id="http_url_with_base64_query_param",
+            id="http_url_with_base64_query_param_with_media_type",
         ),
         pytest.param(
             "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4=",

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f590e32. Configure here.