◐ Shell
clean mode source ↗

Include octokit.graphql.net as a submodule. by grokys · Pull Request #2127 · github/VisualStudio

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@grokys

@grokys grokys commented

Dec 12, 2018

Copy link Copy Markdown

Contributor

This will allow easier debugging/bug fixing and also allows us to include the .pdb files in the vsix.

This also allows us to include the `.pdb` files in the vsix.

@StanleyGoldman StanleyGoldman left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@StanleyGoldman StanleyGoldman merged commit 62d8520 into master

Dec 12, 2018

@StanleyGoldman StanleyGoldman deleted the refactor/octokit-graphql-submodule branch

December 12, 2018 21:00

@meaghanlewis meaghanlewis added this to the 2.6.3 milestone

Jan 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jcansdale jcansdale Awaiting requested review from jcansdale

1 more reviewer

@StanleyGoldman StanleyGoldman StanleyGoldman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@grokys @StanleyGoldman @meaghanlewis