◐ Shell
clean mode source ↗

Prevent error when filenames have braces in them by davidwengier · Pull Request #2512 · github/VisualStudio

Fixes #2510

As per the documentation the OpenComparisonWindow2 method passes captions and tooltips through string.Format so braces break it.

The caption, tooltip, and label parameters use C#-style string formatting where {0} corresponds to the name of the left file and {1} corresponds to the name of the right file.

The existing captions have more detail than using the inbuilt {0} and {1} can provide, particularly as temporary files are used, so there is no option but to escape the braces. I reasoned that since this code is trigger from a UI gesture by the user the perf wasn't super critical so am just doing some lazy replaces. Let me know if thats an issue.