◐ Shell
clean mode source ↗

Treat warnings as errors when building documentation by kiancross · Pull Request #1035 · gitpython-developers/GitPython

Byron

Conversation

@kiancross

Copy link Copy Markdown

Contributor

This fixes all the current warnings when building the documentation and updates the Makefile to treat warnings as errors.

In reference to: #1033

@Byron Byron added this to the v3.1.8 - Bugfixes milestone

Jul 13, 2020

@Byron

Byron commented

Jul 13, 2020

Copy link Copy Markdown

Member

You are on fire! Thanks so much!

With this fix there will be no silent breakage of the documentation anymore, and of course, it has gotten a little better as many of these warnings seem like actual errors or mistakes.
kiancross reacted with thumbs up emoji

@Byron Byron merged commit 30387f1 into gitpython-developers:master

Jul 13, 2020

@kiancross kiancross deleted the fix-documentation-warnings branch

July 13, 2020 14:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.8 - Bugfixes

Development

Successfully merging this pull request may close these issues.

2 participants

@kiancross @Byron