◐ Shell
clean mode source ↗

Fix inheritance issue at commit.iter_items by yvolchkov · Pull Request #1119 · gitpython-developers/GitPython

Conversation

@yvolchkov

The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.

Signed-off-by: Yuri Volchkov yuri@volch.org

The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.

Signed-off-by: Yuri Volchkov <yuri@volch.org>

@yvolchkov

I am not sure the test failure:

   stderr: 'fatal: unable to connect to localhost:
localhost[0: ::1]: errno=Connection refused
localhost[1: 127.0.0.1]: errno=Connection refused

is related to my changes anyhow...

Is that a known issue. Or could someone help me figure out what is wrong?

@Byron

Thanks a lot for the fix!
The tests failed spuriously, which is a rare event on CI.

@yvolchkov

thanks for the quick merge! Are you planning a release soon by any chance? :)

@Byron

2 participants

@yvolchkov @Byron