◐ Shell
clean mode source ↗

lint: switch order Ruff's hooks `fix` -> `format` by Borda · Pull Request #1912 · gitpython-developers/GitPython

Byron

Conversation

@Borda

@Borda Borda commented

May 7, 2024

Copy link Copy Markdown

Contributor

Since fix may do some additional changes, it makes sense to first run fixing and the formatting so you may need to run pre-commit only once in case fixing wont be compatible with formatting

@Byron Byron left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that sounds very reasonable.
Updating the version of ruff at the same time seems like a win, too.
Borda reacted with thumbs up emoji

@Byron Byron merged commit cd490f8 into gitpython-developers:main

May 7, 2024

@Borda Borda deleted the lint/ruff branch

May 7, 2024 19:28

@Borda

Borda commented

May 7, 2024

Copy link Copy Markdown

Contributor Author

@Byron, btw, how about installing this bot?
Byron reacted with thumbs down emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Borda @Byron