fix updating submodules with relative urls by david0 · Pull Request #2051 · gitpython-developers/GitPython
gitpython-developers / GitPython Public
-
-
Notifications
You must be signed in to change notification settings - Fork 980
Merged
merged 1 commit into
Merged
Conversation
david0
commented
Jun 11, 2025
Contributor
This fixes running repo.update_submodules(init=True) on repositories that are using relative for the modules.
It tries to emulate the git behavior: https://github.com/git/git/blob/master/builtin/submodule--helper.c#L503
Fixes #730
This fixes running repo.update_submodules(init=True) on repositories that are using relative for the modules. Fixes gitpython-developers#730
76f3bf3 to
1d80891
Compare
Byron
approved these changes
Byron
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Even though I cannot truly say I know this is correct, there is a test that would probably fail with an exception without the fix so it's better than before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
