BF: Added missing NullHandler to logger in git.remote by bpoldrack · Pull Request #666 · gitpython-developers/GitPython
gitpython-developers / GitPython Public
-
-
Notifications
You must be signed in to change notification settings - Fork 980
Merged
Merged
Conversation
bpoldrack
commented
Aug 31, 2017
bpoldrack
commented
Contributor
Stumbled upon a No handlers could be found for logger "git.remote" message.
Apparently this issue has been addressed in PR #300 already. Back then git/remote.py wasn't included, so here is a one liner to do so.
bpoldrack
mentioned this pull request
bpoldrack
force-pushed
the
bf-nullhandler
branch
from
5e11a68 to
2b3c16c
Compare
Codecov Report
Merging #666 into master will increase coverage by
1.8%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #666 +/- ## ========================================= + Coverage 92.57% 94.38% +1.8% ========================================= Files 61 61 Lines 9968 9970 +2 ========================================= + Hits 9228 9410 +182 + Misses 740 560 -180
| Impacted Files | Coverage Δ | |
|---|---|---|
| git/test/test_remote.py | 97.82% <0%> (ø) |
⬆️ |
| git/refs/remote.py | 91.13% <0%> (+0.02%) |
⬆️ |
| git/compat.py | 63.19% <0%> (+0.22%) |
⬆️ |
| git/refs/symbolic.py | 96.5% <0%> (+0.31%) |
⬆️ |
| git/config.py | 92.76% <0%> (+0.32%) |
⬆️ |
| git/test/test_submodule.py | 99.22% <0%> (+0.38%) |
⬆️ |
| git/test/test_docs.py | 100% <0%> (+0.39%) |
⬆️ |
| git/cmd.py | 85.54% <0%> (+0.47%) |
⬆️ |
| git/repo/base.py | 95.82% <0%> (+0.69%) |
⬆️ |
| git/exc.py | 96.42% <0%> (+1.78%) |
⬆️ |
| ... and 12 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update cf8dc25...2b3c16c. Read the comment docs.
yarikoptic
merged commit
4bbaf1c
into
gitpython-developers:master
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull request
…dler BF: Added missing NullHandler to logger in git.remote
EliahKagan
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment