chore(storage): add pytest for checksum overhead benchmarking by chandra-siri · Pull Request #17422 · googleapis/google-cloud-python
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new microbenchmark script, test_checksum_overhead.py, to measure the performance overhead of checksum validation during range downloads from Google Cloud Storage. The feedback focuses on improving the robustness and efficiency of the benchmark: avoiding hardcoded personal bucket defaults, skipping tests when the required environment variables are missing, making the long warmup duration configurable to speed up test execution, and properly resetting the global event loop state after closing to prevent side effects on subsequent tests.