Allow data: to not be part of sanitizer’s allowed protocols by charmander · Pull Request #412 · html5lib/html5lib-python
charmander
commented
Feb 21, 2019
When data: wasn’t permitted, it could attempt to del attrs[attr] twice.
When `data:` wasn’t permitted, it could attempt to `del attrs[attr]` twice.
Codecov Report
Merging #412 into master will not change coverage.
The diff coverage is100%.
@@ Coverage Diff @@ ## master #412 +/- ## ======================================= Coverage 90.79% 90.79% ======================================= Files 50 50 Lines 6952 6952 Branches 1328 1328 ======================================= Hits 6312 6312 Misses 481 481 Partials 159 159
| Impacted Files | Coverage Δ | |
|---|---|---|
| html5lib/filters/sanitizer.py | 93.16% <100%> (ø) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 4f92357...e4757eb. Read the comment docs.
twm
commented
Mar 2, 2019
twm commented
Contributor
The change looks valid, but shouldn't there be a test case for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters