Replace pkg resources use by loqs · Pull Request #594 · html5lib/html5lib-python
html5lib / html5lib-python Public
-
Notifications
You must be signed in to change notification settings - Fork 307
Open
Open
Conversation
- setup.py: except ImportError for missing pkg_resources
- Missing pkg_resources indicates setuptools 82 or newer which is more recent that than 18.5 so the version check using pkg_resources can safely be skipped.
- This is an alternative to setup.py: handle missing pkg_resources import #592 that avoids using setuptools internal namespace
setuptools._vendor.packaging.version. - Fixes
setuptools> 81 doesn't includepkg_resources#593.
- conftest.py: Replace pkg_resources use with packaging
- This is python 3+ only and intended to be merged after Only support python versions that receive security updates #580
- I can refactor it so it supports 2.7+ if desired.
loqs added 2 commits
Missing pkg_resources indicates setuptools 82 or newer which is more recent that than 18.5 so the version check using pkg_resources can safely be skipped.
loqs
force-pushed
the
replace-pkg_resources-use
branch
from
6a82592 to
41f8aa0
Compare
hroncok
commented
Mar 18, 2026
hroncok commented
Contributor
Thank you.
loqs
commented
Mar 19, 2026
loqs commented
Author
@hroncok appveyor appears to be failing for two reasons:
- py27-optional fails because "Microsoft Visual C++ 9.0" was removed from the "Visual Studio 2022" image which is needed to compile lxml-5.0.2.
- py37-base and py37-optional fail because the Python 3.7 support was removed from the "Visual Studio 2022" image so tox can not run on it.
The py27-optional may be fixable by switching to the "Visual Studio 2015" image. Python 3.7 might require using a source build.
kdesysadmin pushed a commit to KDE/craft-blueprints-kde that referenced this pull request
patch taken from html5lib/html5lib-python#594 issue html5lib/html5lib-python#593 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien added a commit to nextcloud/craft-blueprints-kde that referenced this pull request
patch taken from html5lib/html5lib-python#594 issue html5lib/html5lib-python#593 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment