◐ Shell
clean mode source ↗

Fix appveryor pipelines by loqs · Pull Request #596 · html5lib/html5lib-python

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Open

loqs

wants to merge 2 commits into

Open

Fix appveryor pipelines#596

loqs

wants to merge 2 commits into

Conversation

@loqs

  • Change appveryor's image to Visual Studio 2017 from Visual Studio 2022. Visual Studio 2017 is the most recent Visual Studio image still containing python 3.7.
    • Alternatives:
      • Install python 3.7 on Visual Studio 2022.
      • Switch to a Ubuntu based image.
  • Add upper bound < 5.0.0 to lxml for python 2.7 in requirements-optional.txt.
    • Alternatives:
      • Use an upper bound of < 5.1.0 for Linux and 5.1.0 for Windows.
      • Use an upper bound of 5.1.0 and attempt to build lxml from source.
      • Switch to a Ubuntu based image.
Support for python 2.7 was removed inhttps://pypi.org/project/lxml/5.1.0/.
However there are no python 2.7 wheels for Windows for lxml >- 5.0.0.

@loqs

@cclauss as the last person to touch .appveyor.yml.

@cclauss

I am not a maintainer, so I cannot approve the workflows, etc.

@loqs

@cclauss I apologize for not being clear. Were all appveryor pipelines passing for 4a87368? I tried checking the relevant logs however they are no longer available. Do my suggested changes seem reasonable to you? I am not familiar with appveyor.

cclauss

2 participants

@loqs @cclauss