◐ Shell
clean mode source ↗

Mention correct input frame semantics on XRInputSource/frame by Manishearth · Pull Request #1053 · immersive-web/webxr

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Manishearth

@Manishearth Manishearth commented

May 20, 2020

edited by pr-preview Bot

Loading

Copy link Copy Markdown

Contributor

getViewerPose() step 3 will raise an InvalidStateError with input frames, so the line about views arrays being empty is meaningless since you can't create XRViewerPoses anyway.

fixes #1054


Preview | Diff

@Manishearth Manishearth requested a review from toji

May 20, 2020 17:48

@toji toji left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth Manishearth merged commit efa3f25 into immersive-web:master

May 29, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Event frame pose?

2 participants

@Manishearth @toji