Mention correct input frame semantics on XRInputSource/frame by Manishearth · Pull Request #1053 · immersive-web/webxr
immersive-web / webxr Public
-
Notifications
You must be signed in to change notification settings - Fork 421
Merged
Conversation
Contributor
getViewerPose() step 3 will raise an InvalidStateError with input frames, so the line about views arrays being empty is meaningless since you can't create XRViewerPoses anyway.
fixes #1054
Manishearth
requested a review
from toji
toji
approved these changes
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Manishearth
merged commit
efa3f25
into
immersive-web:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment