During requestAnimationFrame detect if session has ended by cabanier · Pull Request #1169 · immersive-web/webxr
cabanier
marked this pull request as ready for review
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me but remove index.html
| @@ -0,0 +1,8811 @@ | |||
| <!doctype html><html lang="en"> | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't check in index.html
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm used to adding it to .gitignore :-)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-merge LGTM, for what it's worth. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters