◐ Shell
clean mode source ↗

During requestAnimationFrame detect if session has ended by cabanier · Pull Request #1169 · immersive-web/webxr

@cabanier

@cabanier cabanier marked this pull request as ready for review

February 3, 2021 17:36

Manishearth

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me but remove index.html

@@ -0,0 +1,8811 @@
<!doctype html><html lang="en">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't check in index.html

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm used to adding it to .gitignore :-)

@cabanier

toji

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge LGTM, for what it's worth. Thanks!