Rename supportsSessionMode to supportsSession by toji · Pull Request #595 · immersive-web/webxr
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd always sort of preferred this naming anyway ;)
| </div> | ||
|
|
||
| Calling {{XR/supportsSessionMode()}} MUST NOT trigger device-selection UI as this would cause many sites to display XR-specific dialogs early in the document lifecycle without user activation. | ||
| Calling {{XR/supportsSession()}} MUST NOT trigger device-selection UI as this would cause many sites to display XR-specific dialogs early in the document lifecycle without user activation. Additionally, calling {{XR/supportsSession()}} MUST NOT interfere with any running XR applications on the system. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch that this didn't make it over from the explainer. We should probably also make it clear that this should not cause any other applications to launch on the system such as SteamVR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Fixes #592. Brings name inline with requestSession, which now takes the same arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters