Ensure an immersive device is selected in makeXRCompatible() by Manishearth · Pull Request #809 · immersive-web/webxr
| 1. If |context|'s [=XR compatible=] boolean is <code>true</code>, [=/resolve=] |promise| and abort these steps. | ||
| 1. [=ensures an immersive XR device is selected|Ensure an immersive XR device is selected=]. | ||
| 1. If the [=XR/immersive XR device=] is <code>null</code>: | ||
| 1. Set |context|'s [=XR compatible=] boolean to <code>true</code>. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be false, shouldn't it? (It would still allow for inline sessions, which don't check for context compatibility.)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy paste bug 😄
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The create-with-compatible-xr-device algorithm also needs to ensure a device is selected prior to running.
toji
approved these changes
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM