◐ Shell
clean mode source ↗

Handle detached buffers in projectionMatrix by Manishearth · Pull Request #830 · immersive-web/webxr

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Manishearth

Copy link Copy Markdown

Contributor

Fixes #808, all Float32Array attributes should consistently not be [SameObject] and should hadle detached buffers.

r? @toji

@toji

toji commented

Sep 5, 2019

Copy link Copy Markdown

Member

LGTM, thanks for the speedy turnaround!

@toji toji merged commit b2d1bba into immersive-web:master

Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should XRRigidTransform.matrix be [SameObject]?

2 participants

@Manishearth @toji