Check whether a session is inline rather than immersive when appropriate by ddorwin · Pull Request #834 · immersive-web/webxr

ddorwin

Conversation

For steps that are really related to inline sessions, check that directly for clarity.

This also avoids needing to consider things like #817 for these steps.

For steps that are really related to inline sessions, check that directly for clarity.

This also avoids needing to consider things like immersive-web#817 for these steps.

		1. If \|type\| is {{local}} or {{local-floor}}, and \|session\| is an [=immersive session=], return <code>true</code>.
		1. If \|type\| is {{local}} or {{local-floor}}, and the [=XRSession/XR device=] supports reporting orientation data, return <code>true</code>.
		1. If \|type\| is {{bounded-floor}} and \|session\| is an [=immersive session=], return if [=bounded reference spaces are supported=] by the [=XRSession/XR device=].
		1. If \|type\| is {{bounded-floor}} and \|session\| is an [=immersive session=], return the result of whether [=bounded reference spaces are supported=] by the [=XRSession/XR device=].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to phrase this is "the result of executing the Foo algorithm." However, that doesn't seem consistent with how the algorithms are referenced in this spec.

		1. If \|type\| is {{local}} or {{local-floor}}, and \|session\| is an [=immersive session=], return <code>true</code>.
		1. If \|type\| is {{local}} or {{local-floor}}, and the [=XRSession/XR device=] supports reporting orientation data, return <code>true</code>.
		1. If \|type\| is {{bounded-floor}} and \|session\| is an [=immersive session=], return if [=bounded reference spaces are supported=] by the [=XRSession/XR device=].
		1. If \|type\| is {{bounded-floor}} and \|session\| is an [=immersive session=], return the result of whether [=bounded reference spaces are supported=] by the [=XRSession/XR device=].