Rest parameters and spread syntax by Amirhossein-Veysi · Pull Request #142 · javascript-tutorial/fa.javascript.info
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hello @Amirhossein-Veysi and thank you for your contribution;
You should first sign the CLA before I can review your translation, so I mark this as draft since it's not yet ready to be reviewed.
Feel free to mark it as "Ready for review" whenever it was ready. :)
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Hi, Thanks for your review @mahdyar, I tried to solve all problems and now there's no problem, there might be some issue in preview and the reason is the line 122 which wraps the rest of the lines in a code section.
/done
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Should i replace commas in the commented section of codes that are translated? @mahdyar
Should i replace commas in the commented section of codes that are translated? @mahdyar
It's up to you, but I wouldn't.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉