Mouse events by erfanyeganegi · Pull Request #149 · javascript-tutorial/fa.javascript.info
mouse-event-basics
Mouse events
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @erfanyeganegi and thank you for your contribution!
Please consider naming your PR after the article name for future PRs (Read the readme if you haven't):
PR title should match article title, the bot will write it's number into the issue.
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
make the requested changes.
made the requested changes and improved translation.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned some of the problems below, please check it again for any similar problems.
Line numbers shouldn't change.
Comment on lines +59 to +65
| | `event.button` | وضعیت کلید | | ||
| | -------------- | ----------------- | | ||
| | 0 | کلید چپ (اصلی) | | ||
| | 1 | کلید وسط (کمکی) | | ||
| | 2 | کلید راست (ثانوی) | | ||
| | 3 | کلید X1 (عقب) | | ||
| | 4 | کلید X2 (جلو) | |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't add spaces here either.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't change the format of the article. The last back quote is extra.
|
|
||
| ```warn header="Attention: on Mac it's usually `Cmd` instead of `Ctrl`" | ||
| On Windows and Linux there are modifier keys `key:Alt`, `key:Shift` and `key:Ctrl`. On Mac there's one more: `key:Cmd`, corresponding to the property `metaKey`. | ||
| ```warn header="توجه: روی مک معمولا `Cmd`بجای`Ctrl`خواهد بود" روی ویندوز و لینوکس کلیدهای اصلاحکننده `key:Alt`, `key:Shift`و`key:Ctrl`وجود خواهد داشت. روی مک یک کلید دیگر نیز وجود دارد: `key:Cmd`, متناظر خاصیت `metaKey`. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't merge them in one line.
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉