Promise by Beroozam · Pull Request #197 · javascript-tutorial/fa.javascript.info

Beroozam

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Thanks for the translation @Beroozam.
Before I submit a review for other files, I need to know the translation of "Promise".
I think "Promise" doesn't need a translation and it's fine to write it as is.
What do you think @mahdyar?

Thanks for the translation @Beroozam. Before I submit a review for other files, I need to know the translation of "Promise". I think "Promise" doesn't need a translation and it's fine to write it as is. What do you think @mahdyar?

I agree. it should be as it was.

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise.
@mahdiHash
@mahdyar

Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise. @mahdiHash @mahdyar

If you don't know the meaning of a word/sentence and couldn't find it in the glossary, you can ask us in the Translation Help issue.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and create a commit just once (docs).
For now, ignore the suggestions of translation of "settled" until we see what @mahdyar says.

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Hi, @Beroozam.
Are you still working on the changes?
I changed my mind about translation of "settled". I think the meaning you've chosen is fine.
You can add all the suggestions to a batch and submit a commit just once (docs). You only need to separately change the lines which have to be rewritten.

Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

		// runs when the promise is settled, doesn't matter successfully or not
		.finally(() => stop loading indicator)
		// so the loading indicator is always stopped before we process the result/error
		// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه
	// زمانی اجرا می‌شود که promise تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه

Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>

Hi, @Beroozam.
If the translation is ready, please tell us so we merge it :)

Hi, @mahdiHash
It's done and ready. merge it please .

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉