Async/await by ARTM2000 · Pull Request #219 · javascript-tutorial/fa.javascript.info
javascript-tutorial / fa.javascript.info Public
-
Notifications
You must be signed in to change notification settings - Fork 105
Merged
Merged
Async/await#219
Async/await#219
Conversation
ARTM2000 added 2 commits
javascript-translate-bot
added
the
review needed
label
javascript-translate-bot
requested a review
from a team
javascript-translate-bot
mentioned this pull request
mahdyar
requested changes
mahdyar
left a comment
mahdyar
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ARTM2000 and thank you for your contribution!
Please note that there are some tasks and solutions that should also be translated, e.g:
01-rewrite-async/task.md
01-rewrite-async/solution.md
Please translate all the tasks and solutions as well and ask for another review!
javascript-translate-bot
removed
the
review needed
label
javascript-translate-bot
commented
Aug 6, 2022
javascript-translate-bot commented
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
javascript-translate-bot
added
the
changes requested
label
ARTM2000
commented
Aug 7, 2022
ARTM2000 commented
Contributor Author
/done
javascript-translate-bot
added
review needed
and removed
changes requested
labels
javascript-translate-bot
requested a review
from a team
ARTM2000
requested a review
from mahdyar
mahdyar
approved these changes
javascript-translate-bot
added
needs +1
and removed
review needed
labels
mahdyar
requested review from
mahdiHash
and removed request for
mahdiHash
mahdyar
commented
Aug 9, 2022
mahdyar commented
Member
Thank you, @ARTM2000!
mahdyar
merged commit
47df4fa
into
javascript-tutorial:master
javascript-translate-bot
commented
Aug 9, 2022
javascript-translate-bot commented
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
ARTM2000
deleted the
feat/async-await
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment