Promises chaining by mahdiHash · Pull Request #223 · javascript-tutorial/fa.javascript.info
javascript-tutorial / fa.javascript.info Public
-
Notifications
You must be signed in to change notification settings - Fork 105
Merged
Merged
Conversation
mahdiHash
commented
Sep 1, 2022
mahdiHash
commented
Contributor
Please review and comment/commit if anything is wrong.
mahdiHash added 7 commits
javascript-translate-bot
added
the
review needed
label
javascript-translate-bot
requested a review
from a team
javascript-translate-bot
mentioned this pull request
mahdiHash
commented
mahdiHash
commented
mahdiHash
commented
mahdiHash
marked this pull request as ready for review
mahdyar
requested changes
javascript-translate-bot
removed
the
review needed
label
javascript-translate-bot
commented
Sep 2, 2022
javascript-translate-bot commented
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
javascript-translate-bot
added
the
changes requested
label
mahdiHash
commented
Sep 3, 2022
mahdiHash commented
Contributor Author
Thanks for your review, @mahdyar.
/done
javascript-translate-bot
added
review needed
and removed
changes requested
labels
javascript-translate-bot
requested a review
from a team
mahdyar
approved these changes
mahdyar
left a comment
mahdyar
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mahdiHash!
javascript-translate-bot
added
needs +1
and removed
review needed
labels
mahdyar
merged commit
1d3bef6
into
javascript-tutorial:master
javascript-translate-bot
commented
Sep 3, 2022
javascript-translate-bot commented
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment