Comments by Deep1Shikha · Pull Request #77 · javascript-tutorial/hi.javascript.info
All committers have signed the CLA.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are some changes required please address these. And let me know if you need any help. Thanks.
Implemented changes for first review comment
Thanks for the suggestions, I have pushed the changes.
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Thanks for the suggestions, I have pushed the changes.
A few more change requests have been added. Please address those too. Thanks.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. There is this one change I found. After this I think it is ready to get merged.
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you forgot to change वास्तुकला to संरचना at other place. Please change that and request review
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Updated changes as per suggestions
Good work @Deep1Shikha , thanks for contributing. I am merging this PR. Hoping to see many more contributions from you. And Please let your friends and colleagues also know about this project. Thanks 👍
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
Thank you! I am equally enthusiastic and glad. This was my first contribution and it has been merged. I will continue contributing. Grateful to you for your reviews. 🎉