◐ Shell
clean mode source ↗

Added set creation from list by swamishiju · Pull Request #2822 · lcompilers/lpython

swamishiju

@swamishiju

Added functionality for set() to accept list argument

@certik

You have to get the CI to pass, currently it is failing at:

{'returncode': 134} != {'returncode': 1}
{'stderr_hash': '32b0a24f111e577fe4fc5b3f4a5994b951e34dde7986b3fb750c5f5e'} != {'stderr_hash': '4811af471c73572b285e9ea01c8689abdd3cb32c717b3cd4876d2669'}
Diff against: tests/reference/run_dbg-test_assert_01-2f34744.stderr
1,7c1,2
<   File "tests/runtime_errors/test_assert_01.py", line 1
<     def test():
<   File "tests/runtime_errors/test_assert_01.py", line 4
<     test()
<   File "tests/runtime_errors/test_assert_01.py", line 2
<     assert False
< AssertionError
---
> *** buffer overflow detected ***: terminated
> Aborted (core dumped)

@swamishiju

Its weird im on a Mac and python run_tests.py gives all tests passed so im not entirely sure why it isnt working

@ubaidsk

I am observing the same issue here. Probably the CI seems to be flaky.

compiler_tester.tester.RunException: Testing with reference output failed.
runtime_errors/test_assert_01.py * run_dbg
The JSON metadata differs against reference results
Reference JSON: tests/reference/run_dbg-test_assert_01-2f34744.json
Output JSON:    tests/output/run_dbg-test_assert_01-2f34744.json
Omitting 9 identical items
Differing items:
{'returncode': 134} != {'returncode': 1}
{'stderr_hash': '32b0a24f111e577fe4fc5b3f4a5994b951e34dde7986b3fb750c5f5e'} != {'stderr_hash': '4811af471c73572b285e9ea01c8689abdd3cb32c717b3cd4876d2669'}
Diff against: tests/reference/run_dbg-test_assert_01-2f34744.stderr
1,7c1,2
<   File "tests/runtime_errors/test_assert_01.py", line 1
<     def test():
<   File "tests/runtime_errors/test_assert_01.py", line 4
<     test()
<   File "tests/runtime_errors/test_assert_01.py", line 2
<     assert False
< AssertionError
---
> *** buffer overflow detected ***: terminated
> Aborted (core dumped)

ubaidsk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

ubaidsk

ubaidsk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted a comment above. Let's fix the message.

 
Fixed error message

Co-authored-by: Mohammed Ubaid Shaikh <shaikhubaid769@gmail.com>

@swamishiju

Thank you for pointing it out, I've committed it

ubaidsk