alternates: allow relative paths in all repositories by vapier · Pull Request #7019 · libgit2/libgit2
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Merged
Merged
Conversation
vapier
commented
Jan 16, 2025
Contributor
Git does not limit relative paths in alternates to the first repository, so libgit2 shouldn't either.
Git does not limit relative paths in alternates to the first repository, so libgit2 shouldn't either.
vapier
commented
Jan 16, 2025
vapier commented
Contributor Author
The code has behaved this way since it was originally merged in 85e7efa1630855c5c8bd9893f732494bda51b591 in PR #719. I can't see an explanation as to why the code decided to only load relative links for the current repo in either place. Maybe git itself used to behave this way, but current versions definitely do not.
FWIW we hit this in CrOS with details in https://issuetracker.google.com/214563046, although it's not terribly interesting tbh.
ethomson
commented
Jan 21, 2025
ethomson commented
Member
Indeed; I'm not sure either, but it looks like your analysis is correct. Thanks!
3eadce3
into
libgit2:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
